Add reusable url Zod schema for URL props#581
Merged
Conversation
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
{ default: "..." }due to bundlers, so validation should be tolerant and normalize those to strings before type-checking.Description
urlZod schema inlib/common/url.tsthatpreprocess-es values by unwrapping{ default: ... }and then validates asz.string().z.string()usages for URL-like props with the newurlschema inlib/common/cadModel.ts,lib/components/cadmodel.ts,lib/common/layout.ts,lib/components/group.ts, andlib/platformConfig.ts, and updatecadmodelPropsto accepturl.urlschema is reflected ingenerated/COMPONENT_TYPES.md.Testing
bun scripts/generate-component-types.ts,bun scripts/generate-manual-edits-docs.ts,bun scripts/generate-readme-docs.ts, andbun scripts/generate-props-overview.ts, and they completed successfully.bunx tsc --noEmitto type-check the project and it succeeded.bun run formatto format files and it completed successfully.Codex Task